Skip to content

Comments

chore(lint): added unsafe to componentwillreceiveprops#1066

Open
peter7cole wants to merge 1 commit intomomentum-design:mainfrom
peter7cole:comp-will-receive-props
Open

chore(lint): added unsafe to componentwillreceiveprops#1066
peter7cole wants to merge 1 commit intomomentum-design:mainfrom
peter7cole:comp-will-receive-props

Conversation

@peter7cole
Copy link
Contributor

@peter7cole peter7cole commented Sep 21, 2021

Description

Updated all componentWillReceiveProps to UNSAFE_componentWillReceiveProps to silence console warnings

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #1066 (a721ad6) into master (749d769) will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   93.89%   94.16%   +0.27%     
==========================================
  Files         132      132              
  Lines       17258    17258              
  Branches     2552     2554       +2     
==========================================
+ Hits        16204    16251      +47     
+ Misses       1054     1007      -47
Impacted Files Coverage Δ
...b-components/src/components/accordion/Accordion.ts 88.82% <0.00%> (-10.11%) ⬇️
web-components/src/mixins/RovingTabIndexMixin.ts 93.63% <0.00%> (-3.64%) ⬇️
web-components/src/components/label/Label.ts 97.77% <0.00%> (-2.23%) ⬇️
web-components/src/components/avatar/Avatar.ts 94.20% <0.00%> (-1.94%) ⬇️
...mponents/src/components/accordion/AccordionItem.ts 98.85% <0.00%> (-1.15%) ⬇️
...components/src/components/datepicker/DatePicker.ts 89.72% <0.00%> (+1.18%) ⬆️
web-components/src/components/icon/Icon.ts 82.73% <0.00%> (+1.19%) ⬆️
web-components/src/components/list/ListItem.ts 100.00% <0.00%> (+2.94%) ⬆️
web-components/src/components/tabs/Tab.ts 100.00% <0.00%> (+5.39%) ⬆️
web-components/src/components/button/Button.ts 98.61% <0.00%> (+16.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3aaf9...a721ad6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@peter7cole